[PATCH] Minor problems in actsyn.c and overview.c

[Kees Bakker]

Hello,

The following problems were discovered when compiling with
 gcc -Wall.
Perhaps it's an idea to try to use it by default. You'll have to spend a
little bit of work (2 or 3 hours) but the benefit could be cleaner source
code.

Note that the first problem is not vital, but the second could potentially
cause invalid memory access. Perhaps unlikely, but not impossible.

diff -u --recursive --new-file inn-2.2.2.orig/backends/actsync.c inn-2.2.2/backends/actsync.c
--- inn-2.2.2.orig/backends/actsync.c   Mon Dec 13 14:18:37 1999
+++ inn-2.2.2/backends/actsync.c        Wed Jul 12 16:28:38 2000
@@ -1436,7 +1436,7 @@
        case 'y':
                /* of COURSE: collabra has incompatible flags. but it   */
                /* looks like they can be fixed easily enough.          */
-               if (cur->type[1] = 'g') {
+               if (cur->type[1] == 'g') {
                        cur->type[1] = '\0';
                }
        case 'm':
diff -u --recursive --new-file inn-2.2.2.orig/storage/overview.c inn-2.2.2/storage/overview.c
--- inn-2.2.2.orig/storage/overview.c	Mon Dec 13 14:18:37 1999
+++ inn-2.2.2/storage/overview.c	Wed Jul 12 13:50:53 2000
@@ -86,8 +85,9 @@
 */
 STATIC BOOL OVERcheckmmap(UNIOVER *config, OFFSET_T offset, unsigned short len)
 {
-    int i, j, refcount = 0;
-    OFFSET_T pagefudge;
+    int i;
+    int j = 0;
+    int refcount = 0;
 
     if ((config == (UNIOVER *)NULL) || (config->size == 0))
 	return FALSE;

-- 
---------------------------------------------------------------------- 
voice:      +31 33 455 85 84                Tasking Software BV
fax:        +31 33 455 10 05                P.O. Box 899
email:      kees_bakker at tasking.com         3800 AW  Amersfoort
WWW:        http://www.tasking.com          The Netherlands
----------------------------------------------------------------------
     -----  Quality Development Tools Worldwide  -----
            -----------------------------------
Wait a moment... wait a moment... wait a moment...