[PATCH] Minor problems in actsyn.c and overview.c

Russ Allbery rra at stanford.edu
Fri Jul 14 00:18:10 UTC 2000



Kees Bakker <kees_bakker at tasking.nl> writes:

> The following problems were discovered when compiling with
>  gcc -Wall.
> Perhaps it's an idea to try to use it by default. You'll have to spend a
> little bit of work (2 or 3 hours) but the benefit could be cleaner
> source code.

Thanks... once upon a time, I checked a lot of the source with -Wall, but
one of the problems was that I was putting a bunch of band-aids on code
that I really wasn't happy with and that I think needs a complete rewrite
and I didn't want to put too much effort into minor improvements of code
that I don't think we'll keep for the long term.

Most of the new stuff I'm adding compiles correctly under:

  gcc -ansi -pedantic -Wall -W -Wunused -Wshadow -Wpointer-arith
      -Wbad-function-cast -Wcast-qual -Wcast-align -Wwrite-strings
      -Wconversion -Wstrict-prototypes -Wtraditional

I'll get your patch in.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>



More information about the inn-bugs mailing list