Bug in NNTPsendpassword

Adam Wysocki gophi at apcoh.org
Wed Dec 29 23:27:55 UTC 2004


Hi,

In inn 2.4.2, lib/sendpass.c, we have:

    /* What server are we interested in?  Default to the campus one. */
    if (server == NULL
     && (server = innconf->server) == NULL)
        return -1;

Some programs (for example backends/innxmit.c) rely on errno value, 
when returned value is -1. Example:

        if (NNTPsendpassword(REMhost, From, To) < 0 || GotAlarm) {
            i = errno;
            syswarn("cannot authenticate with %s", REMhost);
            syslog(L_ERROR, CANT_AUTHENTICATE,
                REMhost, GotAlarm ? "timeout" : strerror(i));
            /* Don't send quit; we want the remote to print a message. */
            SMshutdown();
            exit(1);
        }

Can this be considered a bug?

-- 
Adam Wysocki * http://www.gophi.rulez.pl/ * GG 1234 * GSM 0508878856



More information about the inn-bugs mailing list