Very small patch against actsync
Holger Wirtz
wirtz at dfn.de
Wed Jan 26 13:52:25 UTC 2000
Hi,
I had problems with actsync and microsoft newsservers. Some of them carry group
names case-insensitive and some do not. So nearly every actsync means that
some groups are flapping because the names are different for actsync.
The son_of_RFC1036 says that groupnames should be used case-insensitive:
[son_of_1036]
NOTE: Possibly newsgroup names should have been
case-insensitive, but all existing software treats
them as case-sensitive. (RFC 977 [rrr] claims
that they are case-insensitive in NNTP, but exist-
ing implementations are believed to ignore this.)
The simplest solution is just to ban use of upper-
case letters, since no widespread newsgroup name
uses them anyway; this avoids any possibility of
confusion.
I made a simple patch against actsync.c (INN-2.2.2):
--- cut here ---
*** actsync.c.orig Wed Jan 26 13:07:47 2000
--- actsync.c Wed Jan 26 14:51:34 2000
***************
*** 1222,1227 ****
--- 1222,1228 ----
}
strncpy(cur->name, line, QIOlength(qp));
cur->name[QIOlength(qp)] = '\0';
+ string_tolower(cur->name); /* wirtz at dfn.de */
/* get the group name */
if ((p = strchr(cur->name, ' ')) == NULL) {
***************
*** 3574,3576 ****
--- 3575,3583 ----
*/
return result;
}
+
+ void string_tolower( char *sz )
+ {
+ while( *sz = tolower( *sz ) ) sz++ ;
+ }
+
--- cut here ---
I hope you can use this in later versions of INN.
Regards, Holger
--
##### #### ## ## Holger Wirtz Phone : (+49 30) 884299-40
## ## ## ### ## DFN-Verein Fax : (+49 30) 884299-70
## ## #### ###### Anhalter Str. 1 E-Mail: wirtz at dfn.de
## ## ## ## ### D-10963 Berlin
##### ## ## ## GERMANY WWW : http://www.dfn.de
More information about the inn-patches
mailing list