innd's code cleanup

[Russ Allbery]

Igor Timkin <ivt at gamma.ru> writes:

> innd's code cleanup (remove unused variables, compiler's warning,
> add prototypes, etc).

Thank you very much for this; this has needed doing.  This should let us
use the compiler to catch bugs in new code much more easily (as before
turning on warnings caused such a flood that it was almost useless).

> Next patch will cleanup rest of inn's code and add
> 	-Wall -W -Wunused -Wshadow -Wpointer-arith -Wbad-function-cast \
> 	-Wcast-qual -Wcast-align -Wwrite-strings -Wstrict-prototypes
> to COPT in Makefile.global.in.

You may want to also add -pedantic.  You probably don't want to turn these
on by default just because we can't assume gcc as the compiler; what I was
planning on doing was adding a new top-level target "make warnings" that
would reinvoke make with COPT set to "-g $(WARNINGS)" so that maintainers
could easily compile with warnings.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>