innd's code cleanup

[Igor Timkin]

Russ Allbery writes:
> > Next patch will cleanup rest of inn's code and add
> > 	-Wall -W -Wunused -Wshadow -Wpointer-arith -Wbad-function-cast \
> > 	-Wcast-qual -Wcast-align -Wwrite-strings -Wstrict-prototypes
> > to COPT in Makefile.global.in.
> 
> You may want to also add -pedantic.  You probably don't want to turn these

With -pedantic (I use this option for test compile) gcc (2.95.2)
type many warning about ``%m'' format in syslog calls.

> on by default just because we can't assume gcc as the compiler; what I was
> planning on doing was adding a new top-level target "make warnings" that
> would reinvoke make with COPT set to "-g $(WARNINGS)" so that maintainers
> could easily compile with warnings.

Agree.

P.S. We need change -O2 optimization to -O (see inn-bugs). -O2 seems
to broken for gcc2.95.2/x86 (or add comment about it to makefile).
With old gcc (2.7.2.3) I used -O3 for inn's make without problems.