Checkgoups and controlchan

[Russ Allbery]

Julien ÉLIE <julien at trigofacile.com> writes:

> I suggest two patches.

> One for control/checkgroups.pl:

> +    if ($#output > 2) {
>      logger($log || 'mail', "checkgroups by $sender", \@output);
> +    }

> Because it sends mails even though there is nothing (and it is a plague
> when, like today, there are lots of checkgroups from the Spanish
> hierarchy).

Why 2?  I want to see the results even if there's only one or two lines in
the results.  Also, shouldn't the message always be logged if the log
method is other than mail?

> And for docheckgroups (for mmap articles, as it has already been
> corrected in controlchan):

> - ${SED} -n '/(Moderated)$/s/[    ].*//p' | sort >${T}/$$ng.mod
> + ${SED} -e 's/\r\?$//' | ${SED} -n '/(Moderated)$/s/[    ].*//p' | sort >${T}/$$ng.mod

> It now knows which groups are moderated.

Why is this necessary?  docheckgroups never receives wireformat articles.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>