Checkgoups and controlchan

[Julien ÉLIE]

En réponse à Russ Allbery :
>> One for control/checkgroups.pl:
> 
>> +    if ($#output > 2) {
>>      logger($log || 'mail', "checkgroups by $sender", \@output);
>> +    }
> 
>> Because it sends mails even though there is nothing (and it is a plague
>> when, like today, there are lots of checkgroups from the Spanish
>> hierarchy).
> 
> Why 2?  I want to see the results even if there's only one or two lines in
> the results.  Also, shouldn't the message always be logged if the log
> method is other than mail?

Well, 1 if you want (I do not know if 0 can be put).
Anyway, if there is an output, its length is > 2 since there are lines
like « # The following newsgroups were missing and should be added. »
and the « exit » one.

Regarding logging, you are right.
Then I suggest :

if ($#output > 1) {
     logger($log || 'mail', "checkgroups by $sender", \@output);
} else {
     logmsg("checkgroups by $sender processed (no change)");
}


Or another thing in logmsg.


>> And for docheckgroups (for mmap articles, as it has already been
>> corrected in controlchan):
> 
>> - ${SED} -n '/(Moderated)$/s/[    ].*//p' | sort >${T}/$$ng.mod
>> + ${SED} -e 's/\r\?$//' | ${SED} -n '/(Moderated)$/s/[    ].*//p' | sort >${T}/$$ng.mod
> 
>> It now knows which groups are moderated.
> 
> Why is this necessary?  docheckgroups never receives wireformat articles.

If manually done.
With a control article named « 1234 », the following two commands are not working well (moderated
groups are not seen):

echo "1234" | controlchan
cat 1234 | docheckgroups

-- 
Julien

« Un ami fidèle qui parle très bien votre langue et toutes
   les langues vivantes : le latin, le grec, le celte, etc. » (Astérix)