innreport errors

[Michael Hall]

On Sat, Nov 06, 1999 at 10:49:55AM +0100, Miquel van Smoorenburg wrote:

> SInce I installed the CVS version of 2 days ago on our reader, I have
> been seeing this in the daily usenet report:
> 
> Incoming articles:
> [snip list of incoming]
> TOTAL: 24:00:02               614317   100.0%    7.11   46.2 GB  100.0%  560.26
> Argument "/var/www/news2/innreport/pics/inn_flow.1999.11.05-01.44...." isn't
> numeric in entersub at /usr/lib/perl5/5.005/i386-linux/GD.pm line 40, <> chunk
> 736609.

  I grabbed the 3.0.2 version from the ftp site, but I'm seeing the same
error also. Took a quick look at it and it wasn't obvious to me, been 
meaning to look into more but there is always so much to do :-(

> Also:
> 
> Outgoing Feeds (innfeed) by Articles:
> [snip list of outgoing]
> TOTAL: 2           202.2 MB   18.4 MB  220.6 MB    1.0 KB/s  228.0 KB  63:06:13
> Use of uninitialized value at /usr/local/news/bin/innreport line 2194, <> chunk
> 736609.
> Use of uninitialized value at /usr/local/news/bin/innreport line 2194, <> chunk
> 736609.

  Haven't seen this one (not using innfeed though :-), I was getting a similar
error though, looking at the source the paragraph above it was similar so I
just did the same thing, this patch fixes the error I was getting:

$ diff -u ../../misc/innreport-3.0.2/innreport_inn.pm innreport_inn.pm
--- ../../misc/innreport-3.0.2/innreport_inn.pm Sun Oct 24 13:49:43 1999
+++ innreport_inn.pm    Mon Oct 25 12:16:03 1999
@@ -210,6 +210,7 @@
     if ($left =~ /^(\w):.*$/o) {
       my $command = $1;
       my $cmd = $ctlinnd{$command};
+      $cmd = $command unless $cmd;
       return 1 if $cmd eq 'flush'; # to avoid a double count
       $innd_control{"$cmd"}++;
       return 1;

<snip>

--
Constipated engineers work it out with a slide rule.

Mike Hall <mhall at riverside.org>, ICQ: #37292579, http://www.riverside.org
System Administrator (MH993) (*nix, OS/2 certified - C, Perl, CGI hacker)