2.3: "paused" nntp channels

[Heath Kehoe]

>Heath Kehoe <heath.kehoe at intermec.com> writes:
>
>> Ok, I'm closer to a solution.  I modified cc.c to print some more info
>> for nntp channels, and found that the cp->HoldTime settings were
>> garbage; they looked like uninitialized values.  So I put in my
>> incoming.conf:  "hold-time: 0" to explicitly set HoldTime, and that
>> fixed the HoldTime settings; and also the "paused" problem.
>
>> So, the root cause is: HoldTime is not getting set to 0 by default.
>> Someone more familiar with RCreadfile() than I am needs to fix that.
>
>That code's rather a mess, but I think I see the problem.  Could you try
>this patch and see if it fixes it?  Looks like the addition of the MaxCnx
>and HoldTime variables was a bit incomplete.
>
>--- rc.c        2000/02/16 15:07:48     1.45
>+++ rc.c        2000/04/13 07:58:32
>@@ -792,6 +792,10 @@
>          groups[groupcount - 2].Pattern : default_params.Pattern;
>        group_params->Password = groupcount > 1 ?
>          groups[groupcount - 2].Password : default_params.Password;
>+        group_params->MaxCnx = groupcount > 1 ?
>+          groups[groupcount - 2].MaxCnx : default_params.MaxCnx
>+        group_params->HoldTime = groupcount > 1 ?
>+          groups[groupcount - 2].HoldTime : default_params.HoldTime
>        if ((word = RCreaddata (&linecount, F, &toolong)) == NULL) {
>          syslog(L_ERROR, LEFT_BRACE, LogName, filename, linecount);
>          break;
>@@ -840,6 +844,10 @@
>          group_params->Pattern : default_params.Pattern;
>        peer_params.Password = groupcount > 0 ?
>          group_params->Password : default_params.Password;
>+        peer_params.MaxCnx = groupcount > 0 ?
>+          group_params->MaxCnx : default_params.MaxCnx;
>+        peer_params.HoldTime = groupcount > 0 ?
>+          group_params->HoldTime : default_params.HoldTime;
>        peer_params.Keysetbit = 0;
> 
>        if ((word = RCreaddata (&linecount, F, &toolong)) == NULL)
>
>-- 
>Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>



This makes it ignore the 'global' settings for those parameters; i.e.,
when you put them outside any peer or group blocks.

-heath