Latest build under FreeBSD

[Russ Allbery]

Javier Henderson <javier at KJSL.COM> writes:

> Using today's snapshot and FreeBSD 3.5-STABLE:

> gcc -g -O2 -I../include   -c dbz.c
> dbz.c:169: warning: `MAP__ARG' redefined
> ../include/clibrary.h:127: warning: this is the location of the previous definition

Yeah, I know about that one; I've been putting off dealing with it until I
get a chance to look at mmap in general in INN and try to avoid the
current #ifdef mess we have now everywhere mmap is used.  It should be
harmless.

> And the following, which appears in about a dozen places:

> gcc  -o nnrpd article.o group.o commands.o loadave.o misc.o newnews.o nnrpd.o perl.o perm.o post.o python.o sasl_config.o tls.o track.o ../storage/libstorage.a ../lib/libinn.a  ../lib/perl.o -Wl,-E /usr/libdata/perl/5.00503/mach/auto/DynaLoader/DynaLoader.a -L/usr/libdata/perl/5.00503/mach/CORE -lperl -lm -lc -lperl    -lutil -lcrypt 
> ../lib/libinn.a(defdist.o): In function `DDstart':
> /export/homea/javier/inn/src/inn/lib/defdist.c:49: warning: mktemp() possibly used unsafely; consider using mkstemp()

INN needs to be converted to use mkstemp everywhere instead; Matus Uhlar
was working on this at one point.  The security vulnerability is largely
non-existent for INN since INN uses its own temporary directory rather
than the system directory, but still it would be nice to use the correct
functions.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>