Duplicate history lines

Alex Kiernan alexk at demon.net
Thu Feb 15 10:52:09 UTC 2001


I've been getting duplicates in my history file for a few days, I
wasn't sure it wasn't the history API work I've been doing, so I've
held off, but I think I've tracked it down to a new bug in art.c; this
is untested (but is the same three lines deleted in the code I'm
developing on and it seems to have fixed it there):

Index: innd/art.c
===================================================================
RCS file: /upstream-repositories/inn-cvs.isc.org/inn/innd/art.c,v
retrieving revision 1.171
diff -u -r1.171 art.c
--- innd/art.c	2001/02/14 15:21:00	1.171
+++ innd/art.c	2001/02/15 10:49:06
@@ -2139,9 +2139,6 @@
   if (HIShavearticle(hash)) {
     sprintf(buff, "%d Duplicate", NNTP_REJECTIT_VAL);
     ARTlog(data, ART_REJECT, buff);
-    if (innconf->remembertrash && (Mode == OMrunning) && !HISremember(hash))
-      syslog(L_ERROR, "%s cant write history %s %m", LogName,
-	HDR(HDR__MESSAGE_ID));
     ARTreject(REJECT_DUPLICATE, cp, article);
     return FALSE;
   }

-- 
Alex Kiernan, Principal Engineer, Development, Thus PLC


More information about the inn-workers mailing list