Fix missed */

Forrest J. Cavalier III mibsoft at epix.net
Tue Feb 27 15:46:48 UTC 2001


Wow!  That patch Alex Kiernan wrote to inn-patches
deserves some comment, (the same way that you have to tell
your friends about any near death miss on the highway.)

The code that got disabled by leaving out the */ is running
SUID root. It is only fortunate happenstance that it wasn't a
big security hole.  (It is just two comments away from disabling
a drop privileges!)

Someone would have probably noticed innfeed was running
as root, but it might have taken several days.  That would
probably have gotten fixed before a release, but a LOT
of people are running snapshots I think.

Alex, I really like the work you have been doing, and I
think it has spurred others to discuss and contribute
also.  I mean, I never thought anyone would endure the
pain of Purify with INN.  Thank you!  Very much!

Forrest

> 
> I'm guessing this was a cockup when the comment was added to the code
> in 1.16 (I spotted it because I was linting & checking my history
> stuff):
> 
> Index: innfeed/startinnfeed.c
> ===================================================================
> RCS file: /upstream-repositories/inn-cvs.isc.org/inn/innfeed/startinnfeed.c,v
> retrieving revision 1.16
> diff -u -r1.16 startinnfeed.c
> --- innfeed/startinnfeed.c	2000/08/29 08:50:51	1.16
> +++ innfeed/startinnfeed.c	2001/02/27 07:27:16
> @@ -79,7 +79,7 @@
>  
>      /* These calls will fail on some systems, such as HP-UX 11.00.  On those
>         systems, we just blindly assume that the stack and data limits are
> -       high enough (they generally are).
> +       high enough (they generally are). */
>  #if HAVE_SETRLIMIT
>      rl.rlim_cur = RLIM_INFINITY;
>      rl.rlim_max = RLIM_INFINITY;
> 
> 
> -- 
> Alex Kiernan, Principal Engineer, Development, Thus PLC
> 
> 



More information about the inn-workers mailing list