[INN-COMMITTERS] inn (9 files)

Russ Allbery rra at stanford.edu
Thu Dec 12 23:36:09 UTC 2002


Alex Kiernan <Alex_Kiernan at isc.org> writes:

>     Date: Thursday, December 12, 2002 @ 08:49:32
>   Author: alexk
>     Path: /dist1/cvs/isc/inn/inn

>    Added: include/tst.h lib/tst_cleanup.c lib/tst_delete.c
>           lib/tst_grow_node_free_list.c lib/tst_init.c lib/tst_insert.c
>           lib/tst_search.c
> Modified: LICENSE lib/Makefile

> Ternary search tree code from Peter A. Friend
> (http://www.octavian.org/cs/tst1.3.tar.gz) under a BSD license

Cool, what will this end up being used for?

A few nits to look at with this code at some point:

 * Is it fairly stable?  If so, I think we should go ahead and assimilate
   it (s/malloc/xmalloc/, s/calloc/xcalloc/, reformat to match our coding
   standards, maybe merge into a single C file, etc.).

 * The lib/tst_grow_node_free_list.c name is pretty long; if we don't
   make it a single file, it may still be worthwhile to shorten that name
   just so that an ls of the lib directory doesn't scroll off the screen.

 * include/tst.h should probably be include/inn/tst.h since it will be an
   installed header file eventually.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>


More information about the inn-workers mailing list