Sleep-deprived debugging successful

Jeffrey M. Vinocur jeff at litech.org
Sun Dec 22 05:43:30 UTC 2002


I think I was right, and that expire/makehistory.c:

-    /* Copy into re-used memory space. */
-    buffer_set(&buffer, p, strlen(p));
+    /* Copy into re-used memory space, including NUL. */
+    buffer_set(&buffer, p, strlen(p)+1);

fixes it.  Testing now, and if so will commit.

By the way, I've accumulated a fair number of duplicate articles as a 
result of this whole confusion (since the history database was effectively 
empty).  If anybody has any suggestions for removing them, do let me know.  
(I think a script to crawl the tradspool tree would suffice, but I'm wary 
of playing around with articles I care about without being sure I've 
thought of all the corner cases.)

-- 
Jeffrey M. Vinocur
jeff at litech.org



More information about the inn-workers mailing list