Sleep-deprived debugging successful
rra at stanford.edu
Sun Dec 22 23:52:10 UTC 2002
Jeffrey M Vinocur <jeff at litech.org> writes:
> I think I was right, and that expire/makehistory.c:
> - /* Copy into re-used memory space. */
> - buffer_set(&buffer, p, strlen(p));
> + /* Copy into re-used memory space, including NUL. */
> + buffer_set(&buffer, p, strlen(p)+1);
> fixes it. Testing now, and if so will commit.
Yeah, this is a correct change regardless. Mea culpa; thank you for
tracking that down!
> By the way, I've accumulated a fair number of duplicate articles as a
> result of this whole confusion (since the history database was
> effectively empty). If anybody has any suggestions for removing them,
> do let me know. (I think a script to crawl the tradspool tree would
> suffice, but I'm wary of playing around with articles I care about
> without being sure I've thought of all the corner cases.)
I don't have any good ideas off-hand, I'm afraid.
Russ Allbery (rra at stanford.edu) <http://www.eyrie.org/~eagle/>
Please send questions to the list rather than mailing me directly.
<http://www.eyrie.org/~eagle/faqs/questions.html> explains why.
More information about the inn-workers