[inn-current] scripts/inncheck & initial setup

Christophe Wolfhugel wolf at oleane.net
Mon Jan 12 18:59:38 UTC 2004


The current setup for this file has a glitch :

1. configure calls config.status which runs a sed in order to
   update @libdir@, etc...

2. make in the scripts dir does not do the fixscript (and if it would
   the @libdir@ substitution would be erased), having inncheck not to
   have the #! substitution at the arrival.

Most variables are defined as $inn::, but not all (@FILEMODE@ for
example).

What would be the best evolution ? Add those missing variables to
innshellvars and do not generate 'inncheck' in the configure script
or have configure replace @_PATH_PERL@ with the right value ?

The 2nd solution is easy to setup :

*** configure   12 Jan 2004 06:10:08 -0000      1.253
--- configure   12 Jan 2004 18:56:06 -0000
***************
*** 18725,18730 ****
--- 18725,18731 ----
  s, at SENDMAIL@,$SENDMAIL,;t t
  s, at DO_DBZ_TAGGED_HASH@,$DO_DBZ_TAGGED_HASH,;t t
  s, at PERL@,$PERL,;t t
+ s, at _PATH_PERL@,$PERL,;t t
  s, at PERL_CPPFLAGS@,$PERL_CPPFLAGS,;t t
  s, at PERL_LIBS@,$PERL_LIBS,;t t
  s, at PYTHON@,$PYTHON,;t t

(I didn't find what has to be modified in configure.ac or others to
get this).

But I would believe that the 1st one would be cleaner : with the
proposed patch, someone modifying innscript.in and then doing a
make again would break 'inncheck'.

-- 
Christophe Wolfhugel -+- wolf at oleane.net -+- France Telecom Transpac
Direction de l'Internet et de l'hébergement
Téléphone : +33 1 4612 6645


More information about the inn-workers mailing list