STABLE: cant store overview

[Russ Allbery]

Patrick Schreurs <patricks at support.nl> writes:

> This happened after upgrading a server from 2.4.1 to
> latest STABLE (20040521):

> May 21 13:21:15 news6 innd: SERVER cant store overview for @030269320000000000000118B46C00000031@
> May 21 13:21:15 news6 innd: SERVER cant store overview for @03026B3200000000000000FDE70A00000031@
> May 21 13:21:15 news6 innd: SERVER throttled Success writing creating overview file -- throttling
> May 21 13:21:15 news6 innd: SERVER throttle Success writing creating overview file -- throttling
> May 21 13:21:15 news6 innd: SERVER cant store overview for @03026C32000000000000013C17CD00000031@
> May 21 13:21:15 news6 innd: SERVER cant write history <10arp5r1e8u763 at news.supernews.com> Success

> Server is xrefslave, but i checked the above articles (they are stored
> in the spool) and the groups exists on the server.  configure parameters
> are the same for 2.4.1 and 2.4.2.

Gah.  Need a better test suite, and I need a test reader box.  I'm really
sorry about that.  This patch will fix; I'll commit it as soon as I work
past some authentication troubles to the CVS repository.

--- inn-2.4/innd/art.c.orig  2004-05-22 17:12:03.000000000 -0700
+++ inn-2.4/innd/art.c       2004-05-22 17:12:27.000000000 -0700
@@ -1750,7 +1750,7 @@
     }
     if (overview->used + overview->left + len > overview->size)
         buffer_resize(overview, overview->size + len);
-    for (i = 0, q = overview->data + overview->left; i < len; p++, q++, i++) {
+    for (i = 0, q = overview->data + overview->left; i < len; p++, i++) {
         if (*p == '\r' && i < len - 1 && p[1] == '\n') {
             p++;
             continue;

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>

    Please send questions to the list rather than mailing me directly.
     <http://www.eyrie.org/~eagle/faqs/questions.html> explains why.