PATCH: fix bug in 2.4.2 dbz.c:getcore()

Russ Allbery rra at stanford.edu
Mon Jun 6 05:04:20 UTC 2005


Chris Caputo <ccaputo at alt.net> writes:

> Hi.  getcore() in inn-2.4.2's lib/dbz.c calls madvise() with an
> incorrect length.  In addition to defeating the purpose of madvise(), on
> Linux this results in extra virtual memory being used since madvise()
> creates a second map when a length does not match an existing map.

> This patch fixes this and cleans up the function a little by adding a
> variable for a common calculation.

> Patch is below and also at:

>   http://www.caputo.com/foss/inn-2.4.2-dbz_getcorefix.patch

Thanks, applied.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>

    Please send questions to the list rather than mailing me directly.
     <http://www.eyrie.org/~eagle/faqs/questions.html> explains why.


More information about the inn-workers mailing list