Bug? in OVadd ??

Heath Kehoe hakehoe at avalon.net
Wed Mar 16 18:13:22 UTC 2005


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Mar 15, 2005, at 12:21, Todd Olson wrote:
>
[...]
>
> QUESTION 1:    Is this a bug?
>                why should a policy violation be treated like technical 
> error?
>                logging the cant stores seems fine with me
>                but then throttling the server?
>
> QUESTION 2:    Is there any other way to deal with it other
>                than trying to craft a 'pattern:' in incoming.conf
>                that only accepts groups in the active file?

I looked at the code... tradindexed returns an error if its _add() 
function
is called on a group that doesn't exist (causing the throttle).  The 
other
overview methods don't do this (they return 'true').

You can fix this by changing the "false" to "true" on about line 191 of
storage/tradindexed/tradindexed.c so that it looks like this:

=======================
     /* Get the group index entry and don't do any work if cutoff is set 
and
        the article number is lower than the low water mark for the 
group. */
     entry = tdx_index_entry(tradindexed->index, group);
     if (entry == NULL)
         return true;
=======================

I'll also make this change in the CVS trees.

- - heath
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)

iD8DBQFCOHdM4uXPAG0A1J4RAtaXAJ9Eys4Y7SeAcHPpE/0JDDWqBtfGGACdEpRb
sEij4n6xLkJyxW4KyM1M5/k=
=KotJ
-----END PGP SIGNATURE-----



More information about the inn-workers mailing list