The fix worked! Re: Bug? in OVadd ??
tco2 at cornell.edu
Mon Mar 21 15:20:48 UTC 2005
The fix you recommended worked! when applied to in-STABALE-20050315
My server is no longer throttling when a message is cross posted
to a group not in my active file.
That was a big help.
Hope this fix will find it's way in to stable.
At 12:13 -0600 2005-03-16, Heath Kehoe wrote:
>-----BEGIN PGP SIGNED MESSAGE-----
>On Mar 15, 2005, at 12:21, Todd Olson wrote:
>> QUESTION 1: Is this a bug?
>> why should a policy violation be treated like technical
>> logging the cant stores seems fine with me
>> but then throttling the server?
>> QUESTION 2: Is there any other way to deal with it other
>> than trying to craft a 'pattern:' in incoming.conf
>> that only accepts groups in the active file?
>I looked at the code... tradindexed returns an error if its _add()
>is called on a group that doesn't exist (causing the throttle). The
>overview methods don't do this (they return 'true').
>You can fix this by changing the "false" to "true" on about line 191 of
>storage/tradindexed/tradindexed.c so that it looks like this:
> /* Get the group index entry and don't do any work if cutoff is set
> the article number is lower than the low water mark for the
> entry = tdx_index_entry(tradindexed->index, group);
> if (entry == NULL)
> return true;
>I'll also make this change in the CVS trees.
>- - heath
>-----BEGIN PGP SIGNATURE-----
>Version: GnuPG v1.2.4 (Darwin)
>-----END PGP SIGNATURE-----
More information about the inn-workers