inn.conf: Support for `newsuser', `newsgrp' options (patch is, hopefully, included)

Julien ÉLIE julien at trigofacile.com
Fri Dec 21 21:14:08 UTC 2007


Hi Russ,

>> By the way, my current patch for INN 2.5 is there, in case someone
>> wishes to test it:
>>
>>     http://iulius.dinauz.org/vrac/newsuser.diff.txt
>>
>> I had to manually do almost all the changes because lots of syntax
>> have changed in the files (logging, paths, checks, etc.).
>
> One quick comment without looking at it in detail: all those int arguments
> should be changed to bools for 2.5 and the corresponding function call
> arguments should be true or false, not 1 or 0.

I have just changed all of these occurrences.
I have also updated the patch above.


> I'd also drop the _p in the option names at that point, since that idiom
> isn't used elsewhere in INN and the bool type provides equivalent
> information.  (Consistency is mostly the concern there; the _p isn't
> wrong.)

Done too.

I have changed the whole thing to use "runasuser" and "runasgroup".
Everything seems to work fine.

-- 
Julien ÉLIE

« -- Comment s'appelle cette ville ?
  -- Divodurum.
  -- N'essaie pas de m'amadouer ! Non, je ne veux pas de rhum ! » (Astérix) 



More information about the inn-workers mailing list