Discrepancies in INNshellvars variables

Julien ÉLIE julien at trigofacile.com
Mon Jul 23 08:48:45 UTC 2007


Hi,

I have just seen the patch <http://launchpadlibrarian.net/3085370/ip>
for Ubuntu to fix innshellvars.pl which is not taint-safe:

--- /usr/lib/news/innshellvars.pl 2006-03-15 11:37:21.000000000 +0100
+++ ./innshellvars.pl 2006-06-15 10:04:28.000000000 +0200
@@ -9,7 +9,11 @@

 package inn ;

-eval `@bindir@/innconfval -p`;
+my $icv = `@bindir@/innconfval -p`;
+my %icv;
+$icv{$icv}++;
+($icv) = keys %icv;
+eval $icv;

 $newshome = $pathnews;


It should perhaps be used.  And also for the Bourne shell script and the Tcl one?



By the way, I looked into innshellvars.* and I do not understand some things.

* First of all, shouldn't the names be standardized?
  I for instance see:
  SPOOLBASE=${PATHSPOOL}
  $spooldir = $pathspool;

  Why isn't it the same for Bourne shell and Perl?


* Shouldn't the EXPORT stuff be the same everywhere?  Some variables are
  exported in the shell script and not in the other scripts.

  SPOOLBASE=${PATHSPOOL}
  export NEWSHOME SPOOL MOST_LOGS
                  ^^^^^

  export NEWSBIN NEWSETC INNDDIR NEWSHOME
                                 ^^^^^^^^
  It should be NEWSLIB and LOCKS.


* In the Perl script:

  $syslog_facility = lc("@SYSLOG_FACILITY@");
  $syslog_facility =~ s/log_//;

  Shouldn't it also be in the shell and the Tcl scripts?


* In the Tcl script, I read:

  set inn_newslbin "${inn_newshome}/local"
  set inn_newsetc "${inn_newshome}/etc"

  Well... Not necessary...


Aren't all the innshellvars.* scripts supposed to have the same stuff in them?

-- 
Julien ÉLIE

« Merci. Pas de sucre. Du lait, un nuage. » (Astérix) 



More information about the inn-workers mailing list