API calls removed from db4.2

Russ Allbery rra at stanford.edu
Mon May 5 18:15:27 UTC 2008


Julien ÉLIE <julien at trigofacile.com> writes:

> http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/inn-db4.patch
>
> It fixes API calls removed from db4.2.
>
> Do you think it should be committed?
> It might perhaps break old Berkeley DB versions (< 4.2?).
> But if such API calls were removed from db4.2, why does it still compile fine
> with current Berkeley DB versions?

If you can get away with it, my recommendation would be to drop support
for all Berkeley DB versions older than something.  I don't know a good
value of something, but for CURRENT I'd be tempted to even assume 4.6.  It
would let you delete a whole ton of ifdef nonsense from the ovdb backend,
and I find it rather unlikely that anyone's seriously attempting to use
ovdb with some of those ancient versions and a current INN.  2.x and 3.x
are particularly lost causes at this point.

Sleepycat doesn't support anything older than 4.6.

The patch generally looks correct to me from my vague memory of the
Berkeley DB API, but I wouldn't want to rely on my memory.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>

    Please send questions to the list rather than mailing me directly.
     <http://www.eyrie.org/~eagle/faqs/questions.html> explains why.


More information about the inn-workers mailing list