[PATCH 0/2] CNFSv4: move to 4K blocksize

Russ Allbery rra at stanford.edu
Sat Nov 29 21:10:30 UTC 2008

list-inn-workers at news.cistron.nl ("Miquel van Smoorenburg" ) writes:

> The values in the article header are stored in network byte order, but
> 'long' can be 32 or 64 bits (and so can time_t).  I think we should make
> 'size' an uint32_t, 'arrived' an int32_t+uint32_t (upper and lower 32
> bits) and 'class' an uint32_t as well.

That sounds good to me.

I'm not sure if the additional work to avoid int64_t is worth it at this
point or if we should just add autoconf logic to find a 64-bit type in
case they don't have the C99 typedef but require a 64-bit type.  I think
all modern OS and compiler combinations have one at this point.  But it
would be the first place in INN that we assume that.

> Is it a good idea to remove the OLD_CNFS code ?

Yes, please.

Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>

    Please send questions to the list rather than mailing me directly.
     <http://www.eyrie.org/~eagle/faqs/questions.html> explains why.

More information about the inn-workers mailing list