innfeed - "blocked sleeping 120" errors"

[Petr Novopashenniy]

Good day, Julien!

On Tue, 14 Apr 2009, Julien ?LIE wrote:

JL> Hi Petr,
JL> 
JL> > I am also concerned that:
JL> > 
JL> > PID USERNAME THR PRI NICE   SIZE    RES STATE  C   TIME   WCPU COMMAND
JL> > 865 news       1  97    0   380M   313M select 1  22.3H  7.81% innd
JL> > 74712 news     1  97    0   259M   257M select 1 216:57  4.30% innfeed
JL> > 74713 news     1  96    0   491M   489M select 1 177:02  2.54% innfeed
JL> > 74714 news     1  96    0 17796K 15760K select 0  64:43  0.34% innfeed
JL> > 
JL> > innfeed-current uses a very large amount of memory.
JL> > 
JL> > I have conducted several tests in our test lab, but I could not get a
JL> > memory leak..
JL> 
JL> Maybe it could become from a thing I fixed on 28 March 2009:
JL> 
JL> Remove useless xstrdup() calls in vector_add().  Memory has been
JL> leaking in both innfeed (since commit 8176) and nnrpd (since
JL> a long time).
JL> 
JL> 
JL> Could you please try it?  Though it should probably not eat 300 MB if
JL> leaking!
JL> 

Yes, it is here.

I "downgrade" inn-CURRENT-20090414 innfeed on our test server:

--- host.c.orig 2009-04-15 16:53:19.000000000 +0400
+++ host.c      2009-04-15 16:57:46.000000000 +0400
@@ -3369,20 +3369,25 @@
   if (host->ipAddrs) {
     int  i;
     char ip_addr[INET6_ADDRSTRLEN];
-    const char *family;
+// pety
+//  const char *family;
+char *family;
 
     for(i = 0; host->ipAddrs[i] != NULL; i++) {
       switch(host->ipAddrs[i]->sa_family) {
         case AF_INET:
-          family = "IPv4";
+//          family = "IPv4";
+       family = xstrdup("IPv4");
           break;
 #ifdef HAVE_INET6
         case AF_INET6:
-          family = "IPv6";
+//          family = "IPv6";
+       family = xstrdup("IPv6");
           break;
 #endif
         default:
-          family = "????";
+//          family = "????";
+       family = xstrdup("????");
           break;


I set up 70 "virtual" (without running innd) peers, and innfeed began to 
consume memory (without any articles). No problem with original 20090414 
innfeed. Yes, I decrease some timers in innfeed.conf.

Thanks, and sorry about I run old 20090327, and ask you questions!

--pety