HDR/OVER/XPAT and keyword generation

[Nix]

On 1 Nov 2009, julien at trigofacile.com said:

> We can change the behaviour of keyword generation.
> Does someone think we should go on regenerating the Keywords: header
> of articles which already have one?

(not me, but you already know that)

>> I was assuming that the point of the keyword generation was that it
>> made those articles which didn't have keywords look as if they did,
>> leaving those which *did* have human-written keywords alone. But it
>> looks like that's not quite what it does...
>
> We do not modify the article, but only its overview data, as it is said
> in INN 2.5.1 documentation:  "In order to use this feature, the regex

Yeah, sorry, I misspoke through rephrasing the response one too many
times (the 'look as if' lost an 'in the overview').

> Incidentally, I have just caught another bug in keyword generation,
> depending on the value of the keylimit: inn.conf parameter.
>
> Just set it to "-5" and innd will die with:

That's just missing parameter validation, presumably.

>    SERVER cant malloc 4294967292 bytes at keywords.c line 138
> Because of a xmalloc().
>
> And also, just set it to "5" and wait for an article containing
> a Keywords: header.  (It also crashes with an article containing a
> very long Keywords: header, with the default "512" value.)
> Because of a memcpy().

Oops! :/