scanlogs: remove special handling of expire.log

[Julien ÉLIE]

Hi Florian,

> in the course of looking at the OLD/expire.log.0 bug, I wondered why
> expire.log would need to be handled specially at all. Turns out there is
> no need, and expire.log is rotated just the same without special
> mention (see patch below).

It seems so.

Incidentally, I have just found out that a warning was in fact never
seen by the user because scanlogs rotates expire.log after the print
of the warning in that file...

--- scripts/news.daily.in       (révision 8737)
+++ scripts/news.daily.in       (copie de travail)
@@ -213,8 +213,9 @@

 test -n "${LOWMARKFILE}" && {
         EXPIREOVERFLAGS="${EXPIREOVERFLAGS} -Z${LOWMARKFILE}"
-        if [ "${DOEXPIREOVER}" != "true" ] ; then
-            echo "lowmark requires expireover" >> ${EXPLOG}
+        if [ "${DOEXPIREOVER}" != "true" ] && [ "${DOMAIL}" = "true" ]
+        then
+            echo "warning:  lowmark requires expireover"
         fi
 }

Or maybe it should also be sent if "nomail" is used?



> BTW has anybody ever thought about replacing scanlogs entirely? I think
> it got its name because it used to do what innreport does much better
> nowadays, and I wonder if the remainder wasn't better cared for using a
> standard program such as logrotate?

I don't know.  Maybe not to depend on logrotate?  But these days, it is
widespread.
It would be yet another thing to configure for the administrator when
he installs INN.  Unless he uses a distribution package (in which case
the packager could configure logrotate).

Amusingly, "man logrotate" mentions:

/var/log/news/* {
    monthly
    rotate 2
    olddir /var/log/news/old
    missingok
    postrotate
        kill -HUP `cat /var/run/inn.pid`
    endscript
    nocompress
}

"The last section defines the parameters for all of the files in
/var/log/news.  Each file is rotated on a monthly basis.  This is
considered a single rotation directive and if errors occur for more than
one file, the log files are not compressed."

INN2 uses "innd.pid" and "unwanted.log", at least, is not supposed
to be rotated this way.

-- 
Julien ÉLIE

« Ave Amiral Cetinconsensus, comme toujours tu as vu juste. » (Astérix)