scanlogs: remove special handling of expire.log

Florian Schlichting fschlich at CIS.FU-Berlin.DE
Wed Nov 11 14:41:10 UTC 2009


Hi Julien,

thanks for committing the patches. It's encouraging to see how quick
this happens! And good to know there's stuff coming to inn2.5 as well...

> Incidentally, I have just found out that a warning was in fact never
> seen by the user because scanlogs rotates expire.log after the print
> of the warning in that file...
> 
> --- scripts/news.daily.in       (révision 8737)
> +++ scripts/news.daily.in       (copie de travail)
> @@ -213,8 +213,9 @@
> 
> test -n "${LOWMARKFILE}" && {
>         EXPIREOVERFLAGS="${EXPIREOVERFLAGS} -Z${LOWMARKFILE}"
> -        if [ "${DOEXPIREOVER}" != "true" ] ; then
> -            echo "lowmark requires expireover" >> ${EXPLOG}
> +        if [ "${DOEXPIREOVER}" != "true" ] && [ "${DOMAIL}" = "true" ]
> +        then
> +            echo "warning:  lowmark requires expireover"
>         fi
> }
> 
> Or maybe it should also be sent if "nomail" is used?

I think so, it's a mistake the admin might not notice for a long time.


> >BTW has anybody ever thought about replacing scanlogs entirely? I think
> >it got its name because it used to do what innreport does much better
> >nowadays, and I wonder if the remainder wasn't better cared for using a
> >standard program such as logrotate?
> 
> I don't know.  Maybe not to depend on logrotate?  But these days, it is
> widespread.
> It would be yet another thing to configure for the administrator when
> he installs INN.  Unless he uses a distribution package (in which case
> the packager could configure logrotate).
> 
> Amusingly, "man logrotate" mentions:
... 
> INN2 uses "innd.pid" and "unwanted.log", at least, is not supposed
> to be rotated this way.

plus the syslog files would need to notify syslogd, and innreport could
be called in postrotate before compression; so the logrotate
configuration won't be that short. And careful, innd will terminate on
SIGHUP, but 'ctlinnd flushlogs' will already do a little rotation by
itself... I feel it's not going to be an easy operation, but I might
investigate if I can make time next year. I like the thought of easily
using "dateext"

Florian



More information about the inn-workers mailing list