[patch] actsync rejects hannover._wichtig

[Julien ÉLIE]

Hi Florian,

> You almost fooled me... or I fooled you. Lines 1142 to 1152 have to be
> looked at together, and what would need to be amended is of course line
> 1146 (isalpha()...) so that non_num will be set to true:

OK, now done.

--- backends/actsync.c  (révision 9001)
+++ backends/actsync.c  (copie de travail)
@@ -1140,12 +1138,13 @@
        return 1;
     }

-    /* must start with an alphanumeric ascii character */
+    /* must start with an ascii character */
     if (!isascii(name[0])) {
        return 1;
     }
     /* set non_num as needed */
-    if (isalpha((int)name[0])) {
+    if (isalpha((int)name[0])
+        || name[0] == '+' || name[0] == '-' || name[0] == '_') {
        non_num = true;
     } else if ((int)isdigit((int)name[0])) {
        non_num = false;



> I think it would be best to follow the actsync approach and have a
> global configuration variable num_chk or allownumericgroup or some such.
> And even if forbidden innd would still need to accept the article if
> it's crossposted to some other valid group, right?

Yes.

And more generally, actsync should be able to cope up with canonized
UTF-8 newsgroup names...



> What I meant to say is that I don't think the strspn() in that line has
> any effect in practice, and it's probably not meant that way - or am I
> overlooking something here?

It only forbids newsgroups whose name is a digit:

% ctlinnd newgroup 42
ctlinnd: Illegal newsgroup name

-- 
Julien ÉLIE

« E Roma nemo te diuidet omen amore. »