innfeed -s option?

Florian Schlichting fschlich at CIS.FU-Berlin.DE
Mon Jan 24 13:33:58 UTC 2011


Hi Julien,

On Sun, Jan 23, 2011 at 10:22:40PM +0100, Julien ÉLIE wrote:
> In the source code, I read:
> 
> -s command : run the given command in a subprocess and use its
> output as article information instead of running under innd

oh, thanks, I didn't look in that corner...

> so I believe it is used if someone wants to feed the output of a
> long-running script to innfeed.  It keeps running and waiting for
> output.  (I think that if innfeed is directly piped, it processes
> the output once and then exits.)

I'm not sure about that; I'd think in that case innfeed keeps running
until the script exits / closes the pipe, and that's the same for -s
subprocesses or pipes from innd. The big difference for innd operation
is that innfeed is spawned as an innd channel feed, i.e. it will be
respawned by innd if it dies or after the pipe is closed e.g. during a
reload of the newsfeeds file.

Anyway, here's the revised version of my patch:

Subject: [PATCH] innfeed: properly document -o and -s options in both manpage and online help

---
 doc/man/innfeed.1 |   12 ++++++++++--
 innfeed/main.c    |    3 +++
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/doc/man/innfeed.1 b/doc/man/innfeed.1
index 8a52de2..d8e7c73 100644
--- a/doc/man/innfeed.1
+++ b/doc/man/innfeed.1
@@ -54,6 +54,9 @@ innfeed \- multi-host, multi-connection, streaming NNTP feeder.
 .B \-p file
 ]
 [
+.B \-s command
+]
+[
 .B \-S file
 ]
 [
@@ -432,9 +435,14 @@ The ``\fI\-p\fP'' flag is used to specify the filename to write the pid of the
 process into. A relative path is relative to <pathrun\ in\ inn.conf>. The
 default is ``\fIinnfeed.pid\fP''.
 .TP
+.B \-s
+The ``\fI\-s\fP'' flag specifies the name of a command to run in a subprocess
+and read article information from. This is similar to channel mode operation,
+only that <command> takes the place usually occupied by innd.
+.TP
 .B \-S
 The ``\fI\-S\fP'' flag specifies the name of the file to write the periodic
-staus to. If the path is relative it is considered relative to
+status to. If the path is relative it is considered relative to
 <pathlog\ in\ inn.conf>. The default is ``\fIinnfeed.status\fP''.
 .TP
 .B \-v
@@ -481,7 +489,7 @@ matter how big the ``max-connectiond'' field specifies. Thus a value
 of 0 for ``initial-connections'' means nothing will happen in ``-x''
 mode.
 .PP
-Innfeed does not automatically grab the file out of out.going--this needs
+Innfeed does not automatically grab the file out of outgoing--this needs
 to be prepared for it by external means.
 .PP
 Probably too many other bugs to count.
diff --git a/innfeed/main.c b/innfeed/main.c
index cb10bfb..6134d46 100644
--- a/innfeed/main.c
+++ b/innfeed/main.c
@@ -517,6 +517,9 @@ static void usage (int val)
   fprintf (stderr,"\t            (a no-op as this excutable has been built without mmap support\n") ;
 #endif
 
+  fprintf (stderr,"\t-o bytes    Set a limit for the maximum number of bytes of article\n");
+  fprintf (stderr,"\t            data innfeed is supposed to keep in memory.\n");
+
   fprintf (stderr,"\t-p file     Write the process id to the given file\n") ;
   fprintf (stderr,"\t            instead of the default of %s\n",PID_FILE);
   fprintf (stderr,"\t            A relative path is relative to %s\n", innconf->pathrun) ;



Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5557 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/inn-workers/attachments/20110124/54b0d5d4/attachment.bin>


More information about the inn-workers mailing list