innfeed busy logging timer stats

Julien ÉLIE julien at trigofacile.com
Fri Jun 24 17:49:12 UTC 2011


Hi Florian,

Thanks for your patch.
I have just committed it with the following changes:


> @@ -1392,15 +1392,13 @@ static void doTimeout (void)
>   #define BUFF_SIZE 100
>
>
> -void timerCallback (void *cd) ;
> -void timerCallback (void *cd)
> +static void timerCallback (void *cd)
>   {
>     d_printf (1,"Callback \n") ;
>   }

I have totally removed this function because it is never called in the 
whole innfeed source code.



> -void lineIsRead (EndPoint myEp, IoStatus status, Buffer *buffer, void *data);
> -void lineIsRead (EndPoint myEp, IoStatus status, Buffer *buffer, void *d)
> +void lineIsRead (EndPoint myEp, IoStatus status, Buffer *buffers, void *d UNUSED)
>   {
>     Buffer *writeBuffers, *readBuffers ;
>     Buffer newBuff1, newBuff2 ;

I have made this function static.



> -void newConn (EndPoint ep, IoStatus status, Buffer *buffer, void *d) ;
> -void newConn (EndPoint ep, IoStatus status, Buffer *buffer, void *d)
> +static void newConn (EndPoint ep, IoStatus status, Buffer *buffers UNUSED, void *d UNUSED)
>   {
>     EndPoint newEp ;
>     struct sockaddr_in in ;

The "status" variable is also unused in the function.



>   int prepareWrite (EndPoint endp,
> -                   Buffer *buffs,
> +                   Buffer *buffers,
>                     EndpRWCB progress,
>                     EndpRWCB done,
>                     void *clientData) ;

An argument was missing in the source code when the function is called. 
  I changed:

-  prepareWrite (myEp,writeBuffers,lineIsWritten,NULL) ;

to:

+  prepareWrite(myEp, writeBuffers, NULL, lineIsWritten, NULL);

in endpoint.c.

Have a nice week-end,

-- 
Julien ÉLIE

« Ce n'est pas en tournant le dos aux choses qu'on leur fait face. »
   (Pierre Dac)



More information about the inn-workers mailing list