INN 2.5.3 release candidate

[Jeffrey M. Vinocur]

On Mon, 26 Sep 2011, Julien ÉLIE wrote:

> A release candidate for INN 2.5.3 has just been made available
> for download at Russ' web site:
>
>    http://archives.eyrie.org/software/inn/testing/

Excellent.

(Silly question, do we stable have STABLE / CURRENT as we did in CVS?  I 
have only the trunk checked out in svn and don't quite see how I would get 
a different branch.)


Several issues noted:


(1) FYI, I get a bunch of the following warnings on `make` (gcc version 
4.4.3 -- Gentoo 4.4.3-r2 p1.2); if I do `make warnings` they get promoted 
to errors and compilation fails.


conffile.c:13: warning: ignoring return value of 'fgets', declared with 
attribute warn_unused_result
rc.c:189: warning: ignoring return value of 'write', declared with 
attribute warn_unused_result
rc.c:669: warning: ignoring return value of 'fgets', declared with 
attribute warn_unused_result
rc.c:689: warning: ignoring return value of 'fgets', declared with 
attribute warn_unused_result
rc.c:707: warning: ignoring return value of 'fgets', declared with 
attribute warn_unused_result
misc.c:279: warning: ignoring return value of 'write', declared with 
attribute warn_unused_result
newnews.c:289: warning: ignoring return value of 'nice', declared with 
attribute warn_unused_result
nnrpd.c:984: warning: ignoring return value of 'nice', declared with 
attribute warn_unused_result
post.c:850: warning: ignoring return value of 'fgets', declared with 
attribute warn_unused_result
endpoint.c:1091: warning: ignoring return value of 'writev', declared with 
attribute warn_unused_result
misc.c:81: warning: ignoring return value of 'chdir', declared with 
attribute warn_unused_result
makehistory.c:324: warning: ignoring return value of 'fwrite', declared 
with attribute warn_unused_result
makehistory.c:403: warning: ignoring return value of 'fwrite', declared 
with attribute warn_unused_result
rnews.c:956: warning: ignoring return value of 'fgets', declared with 
attribute warn_unused_result
actsync.c:1096: warning: ignoring return value of 'fgets', declared with 
attribute warn_unused_result
archive.c:406: warning: ignoring return value of 'freopen', declared with 
attribute warn_unused_result
batcher.c:267: warning: ignoring return value of 'freopen', declared with 
attribute warn_unused_result
buffchan.c:418: warning: ignoring return value of 'freopen', declared with 
attribute warn_unused_result
filechan.c:116: warning: ignoring return value of 'chown', declared with 
attribute warn_unused_result
innbind.c:324: warning: ignoring return value of 'write', declared with 
attribute warn_unused_result
innbind.c:326: warning: ignoring return value of 'write', declared with 
attribute warn_unused_result
tradindexed/tdx-util.c:144: warning: ignoring return value of 'fwrite', 
declared with attribute warn_unused_result
tradindexed/tdx-util.c:146: warning: ignoring return value of 'fwrite', 
declared with attribute warn_unused_result



(2) FYI, running `make check` before `make` fails as:

~/inn/inn-2.5.3rc1 > make check
cd tests && make test || exit 1 ; cd ..
make[1]: Entering directory `/home/jeff/inn/inn-2.5.3rc1/tests'
gcc -g -O2 -I../include  -DSOURCE='"/home/jeff/inn/inn-2.5.3rc1/tests"' 
-DBUILD='"/home/jeff/inn/inn-2.5.3rc1/tests"' -I. -c -o 
authprogs/ident-t.o authprogs/ident-t.c
In file included from ../include/config.h:4,
                  from authprogs/ident-t.c:4:
../include/inn/defines.h:22:24: error: inn/system.h: No such file or 
directory
In file included from ../include/config.h:4,
                  from authprogs/ident-t.c:4:
../include/inn/defines.h:56: error: two or more data types in declaration 
specifiers
../include/inn/defines.h:56: warning: useless type name in empty 
declaration
authprogs/ident-t.c: In function 'client':
authprogs/ident-t.c:29: warning: ignoring return value of 'read', declared 
with attribute warn_unused_result
authprogs/ident-t.c: In function 'main':
authprogs/ident-t.c:140: warning: ignoring return value of 'chdir', 
declared with attribute warn_unused_result
make[1]: *** [authprogs/ident-t.o] Error 1
make[1]: Leaving directory `/home/jeff/inn/inn-2.5.3rc1/tests'
make: *** [check] Error 1


(3) Eventually I was able to get the tests to run, and:

Failed Set                 Fail/Total (%) Skip Stat  Failing Tests
-------------------------- -------------- ---- ----  -------------
lib/getnameinfo               1/26     4%    0    0  14

Failed 1/2906 tests, 99.97% okay, 27 tests skipped.


The failed one is:

# wanted: biff
#   seen: comsat
not ok 14

I guess this is a synonym on some linux distributions, we could ignore it, 
substitute a different service, or permit either name (I don't see 
any way to do this with ok_string() but I guess we could just do the 
string comparisons directly inside of an ok().)


Otherwise so far looking good.


-- 
Jeffrey M. Vinocur
jeff at litech.org