INN 2.5.3 release candidate

[Julien ÉLIE]

Hi Jeff,

Thanks for your message about this release candidate.


> do we have STABLE / CURRENT as we did in CVS? I
> have only the trunk checked out in svn and don't quite see how I would
> get a different branch.

If you only have trunk, then it means you have checked out the "trunk" 
subdirectory:
     http://inn.eyrie.org/svn/trunk

STABLE 2.5 can be checked out this way:
     svn co http://inn.eyrie.org/svn/branches/2.5 inn-2.5

or, as you are a committer, your can also check it out with:
     svn co svn+ssh://inn.eyrie.org/srv/svn/inn/branches/2.5 inn-2.5



> conffile.c:13: warning: ignoring return value of 'fgets', declared with
> attribute warn_unused_result
> rc.c:189: warning: ignoring return value of 'write', declared with
> attribute warn_unused_result
> newnews.c:289: warning: ignoring return value of 'nice', declared with
> attribute warn_unused_result
> endpoint.c:1091: warning: ignoring return value of 'writev', declared
> with attribute warn_unused_result
> misc.c:81: warning: ignoring return value of 'chdir', declared with
> attribute warn_unused_result
[...]

I will have to look at all the lines you mention, and see if they can be 
cast to void without problem or if they need careful error handling with 
a check of their return value.



> (2) FYI, running `make check` before `make` fails

I suggest to force "make all" when "make check" is used.


--- Makefile	(révision 9380)
+++ Makefile	(copie de travail)
@@ -185,7 +185,7 @@


  ##  Run the test suite.
-check test tests:
+check test tests: all
  	cd tests && $(MAKE) test || exit 1 ; cd ..




> (3) Eventually I was able to get the tests to run, and:
>
> Failed Set Fail/Total (%) Skip Stat Failing Tests
> -------------------------- -------------- ---- ---- -------------
> lib/getnameinfo 1/26 4% 0 0 14
>
> Failed 1/2906 tests, 99.97% okay, 27 tests skipped.
>
>
> The failed one is:
>
> # wanted: biff
> # seen: comsat
> not ok 14
>
> I guess this is a synonym on some linux distributions, we could ignore
> it, substitute a different service, or permit either name (I don't see
> any way to do this with ok_string() but I guess we could just do the
> string comparisons directly inside of an ok().)

I also do not know how it can be achieved with C TAP Harness.
Maybe a new function expecting a vector of a specified type (int, 
double, string or hex -- the currently recognized types by C TAP 
Harness) is needed.

The test (in TRUNK) corresponds to:

ok 14 - ...and found biff

     status = test_getnameinfo(sa, sizeof(sin), NULL, 0, service,
                               sizeof(service), NI_DGRAM);
     is_int(0, status, "lookup of 512 UDP");
     serv = getservbyname("biff", "udp");
     if (serv == NULL)
         skip("biff service not found");
     else
         is_string("biff", service, "...and found biff");

-- 
Julien ÉLIE

« Deficiente uino, deficit omne. »