INN 2.5.3 release candidate

Russ Allbery rra at stanford.edu
Sat Oct 15 20:06:08 UTC 2011


Julien ÉLIE <julien at trigofacile.com> writes:

> The test (in TRUNK) corresponds to:

> ok 14 - ...and found biff

>     status = test_getnameinfo(sa, sizeof(sin), NULL, 0, service,
>                               sizeof(service), NI_DGRAM);
>     is_int(0, status, "lookup of 512 UDP");
>     serv = getservbyname("biff", "udp");
>     if (serv == NULL)
>         skip("biff service not found");
>     else
>         is_string("biff", service, "...and found biff");

I'd do something like:

    if (serv == NULL)
        skip("biff service not found");
    else if (strcmp(serv, "comsat") == 0)
        is_string("comsat", service, "...and found biff");
    else
        is_string("biff", service, "...and found biff");

I'll make this change in rra-c-util.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>

    Please send questions to the list rather than mailing me directly.
     <http://www.eyrie.org/~eagle/faqs/questions.html> explains why.



More information about the inn-workers mailing list