[PATCH] innfeed does not reopen (rotated) log file

[Russ Allbery]

Florian Schlichting <fschlich at CIS.FU-Berlin.DE> writes:

> getting back to the original issue, an innfeed daemon on a funnel feed
> keeping open a log file long deleted by scanlogs:

> On Wed, Aug 08, 2012 at 10:54:57AM +0200, Florian Schlichting wrote:
>> I just noticed that innfeed keeps open a deleted log/innfeed.log, while
>> the current log/innfeed.log as well as all the available OLD logs are
>> empty!
>> 
>> The reason seems to be that rotation of innfeed.log was added to
>> scanlogs for INN 2.5, but scanlogs doesn't send a signal for innfeed to
>> reopen its log; and indeed there is (currently) no way to cause a
>> running innfeed to do so. 
>> 
>> I think the assumption in scanlogs is that the LIVEFILES may be opened
>> for writing at any time, even while scanlogs is processing them, but
>> will only be held open for a short while. This is probably true for the
>> other LIVEFILES (${NNTPSEND} ${SENDNNTP} ${SENDUUCP}), but innfeed.log
>> is opened once at innfeed startup as its stdout and stderr, and remains
>> open during its entire lifetime - which in funnel-file mode can be quite
>> long!

> Following is the patch I have been running with for the past month or
> so, making scanlogs keep its hands off log/innfeed.log:

I have (finally) applied this patch to CURRENT and to the 2.5 branch.
Thanks!  It's less than ideal, since innfeed really needs some mechanism
to let go of that file, but it's better than what we're currently doing.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>