[PATCH] innfeed does not reopen (rotated) log file

Jeffrey M. Vinocur jeff at litech.org
Mon Jan 14 09:49:14 UTC 2013


On Mon, 7 Jan 2013, Russ Allbery wrote:

> Julien ÉLIE <julien at trigofacile.com> writes:
>
>> The only issue I could think of is that the current sighup() function
>> reloads innfeed.conf.  This file would therefore be reloaded everyday,
>> which might cause a problem if it has changed and the news administrator
>> still has not wanted to reload it.  An automatic reload of innfeed.conf
>> would then have innfeed shut down (if for instance the syntax of the new
>> innfeed.conf file is wrong).
>
> Ah, hm, yes, that's true.  That would be fine with me, but I could see how
> it might be surprising.  We should probably only do that for 2.6.
>
> Does anyone have any concerns about this and think we should add a
> separate signal for log rotation?

Doesn't bother me.  Innfeed is always kinda doing its own thing anyway.


-- 
Jeffrey M. Vinocur
jeff at litech.org


More information about the inn-workers mailing list