[PATCH] innfeed does not reopen (rotated) log file
fschlich at cis.fu-berlin.de
Wed Jan 16 10:02:07 UTC 2013
On Mon, Jan 07, 2013 at 11:22:59AM -0800, Russ Allbery wrote:
> Julien ÉLIE <julien at trigofacile.com> writes:
> > The only issue I could think of is that the current sighup() function
> > reloads innfeed.conf. This file would therefore be reloaded everyday,
> > which might cause a problem if it has changed and the news administrator
> > still has not wanted to reload it. An automatic reload of innfeed.conf
> > would then have innfeed shut down (if for instance the syntax of the new
> > innfeed.conf file is wrong).
> Ah, hm, yes, that's true. That would be fine with me, but I could see how
> it might be surprising. We should probably only do that for 2.6.
> Does anyone have any concerns about this and think we should add a
> separate signal for log rotation?
It's the same as what other daemons (e.g. apache2) do after log rotation
/ on SIGHUP, so it shouldn't come as too much of a surprise IMHO.
Related to the original issue, yesterday I noticed that ninpaths and
controlchan have a deleted log/OLD/errlog on stdout and stderr. Perhaps
'ctlinnd flushlogs' as used in scanlogs should also cause flushing of
all channel / exploder feeds?
PS: insignificant typo:
@@ -638,7 +638,7 @@ at its leisure. File feeds are most frequently used in combination with
A program feed (B<Tp>) spawns a given program for every article that the
-site receives. The I<paramter> field must be the command line to execute,
+site receives. The I<parameter> field must be the command line to execute,
and should contain one instance of C<%s>, which will be replaced by the
storage API token of the article (the actual article can be retrieved by
the program using sm(8)). The program will not receive anything on
More information about the inn-workers