INN patches following static analysis

Julien ÉLIE julien at trigofacile.com
Sun May 3 15:31:48 UTC 2015


Hi Richard,

> I put INN through a static analyzer.  There were quite a lot of
> issues detected; I've not studied them all yet but attached are some
> patches that address the first ones I looked at.

Many thanks for your patches.  They are all integrated to CURRENT 
(2.6.0).  I will soon also commit them to STABLE (2.5.5).


> [PATCH 4/5] Paranoid checking of AUTHINFO GENERIC reply
>
> + Reply("%d Program error occurred\r\n", NNTP_FAIL_ACTION,
> +       strerror(errno));

I removed the errno part in the commit.



> Subject: [PATCH 3/5] Correct sense of PERMgeneric reply
>
> The comment has always been wrong.  The return value has been wrong
> for ~15 years.  Perhaps it would be better to remove this code
> entirely.

Yep, that's a pretty good catch!  I bet that nobody ever used AUTHINFO 
GENERIC with INN 2.x...

-- 
Julien ÉLIE

« – Vous refusez de porter pilum ?
   – Ben… On préfère se faire porter pâles… » (Astérix)


More information about the inn-workers mailing list