INN patches following static analysis

Richard Kettlewell rjk at greenend.org.uk
Sun May 3 14:36:07 UTC 2015


Hello,

I put INN through a static analyzer. There were quite a lot of issues
detected; I've not studied them all yet but attached are some patches
that address the first ones I looked at.

The results pass 'make check' but I've not attempted to install and run
the modified version.

ttfn/rjk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Avoid-violating-C-aliasing-rules.patch
Type: text/x-patch
Size: 1313 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/inn-workers/attachments/20150503/1db7e2ff/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Paranoid-checking-of-AUTHINFO-GENERIC-reply.patch
Type: text/x-patch
Size: 1375 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/inn-workers/attachments/20150503/1db7e2ff/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Correct-sense-of-PERMgeneric-reply.patch
Type: text/x-patch
Size: 1374 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/inn-workers/attachments/20150503/1db7e2ff/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Don-t-dereference-a-null-pointer-if-there-are-no-acc.patch
Type: text/x-patch
Size: 606 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/inn-workers/attachments/20150503/1db7e2ff/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Correctly-log-malformed-Xref-fields.patch
Type: text/x-patch
Size: 942 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/inn-workers/attachments/20150503/1db7e2ff/attachment-0004.bin>


More information about the inn-workers mailing list