INN patches following static analysis

[Julien ÉLIE]

Hi Richard,

>>> [PATCH 4/5] Paranoid checking of AUTHINFO GENERIC reply
>>>
>>> + Reply("%d Program error occurred\r\n", NNTP_FAIL_ACTION,
>>> +       strerror(errno));
>>
>> I removed the errno part in the commit.
>
> Oh, well spotted, sorry about that.

No problem.  I wish to thank you again for your help to improve the 
robustness of INN.



>> Subject: [PATCH 3/5] Correct sense of PERMgeneric reply
>>
>> The return value has been wrong for ~15 years.
>
> I bet that nobody ever used AUTHINFO GENERIC with INN 2.x...

In fact, since INN 2.4.0 because the code up to 2.3.5 seems right.
If you don't mind, I will add your name to our CONTRIBUTORS file as I 
see you currently are not mentioned herein.

-- 
Julien ÉLIE

« – Vous refusez de porter pilum ?
   – Ben… On préfère se faire porter pâles… » (Astérix)