[PATCH] fix snprintf return value misuse (and some related off-by-1/etc)

Julien ÉLIE julien at trigofacile.com
Tue Sep 6 20:18:39 UTC 2016


Hi Yuriy,

>> Is that change really necessary, as TMRsumone() can no longer return
>> a negative value or a value greater than the supplied buffer size?
>
> Well, yes, this change is redundant with changed TMRsumone().
> (I tried to be consistent with snprintf()-calling code, but now that I
> looked at it again, it is not consistent with other TMRsumone call-sites
> anyway; so, this chunk should be dropped).

OK, many thanks for your confirmation.

Your patches are included in INN (and will be shipped with the 
forthcoming 2.6.1 version) as well as rra-c-util from where a few files 
come.

   https://inn.eyrie.org/trac/changeset/10062
   https://inn.eyrie.org/trac/changeset/10068
 
https://git.eyrie.org/?p=devel/rra-c-util.git;a=commitdiff;h=7c034de48792363891ebbb2185ec3df739893a7d

-- 
Julien ÉLIE

« – Par Toutatis ! On tire encore sur nous !
   – Nous sommes au dessus de Tyr.
   – Alors tirons-nous vite ! » (Astérix)


More information about the inn-workers mailing list