No Injection-Date: if Message-ID: present?

Julien ÉLIE julien at trigofacile.com
Sun Sep 17 13:00:32 UTC 2017


Hi Thomas,

> Wouldn't it help to add such a sentence to the documentation, e.g. to
> the inn.conf man page?

Sure.


> I'll attach a patch (which will need some polishing ...).

Here is a suggestion of polishing.  Is it OK for you?


--- inn.conf.pod	(révision 10171)
+++ inn.conf.pod	(copie de travail)
@@ -861,9 +861,16 @@
 
 =item I<addinjectiondate>
 
-Whether to add an Injection-Date: header to all local posts.  This is a
-boolean value and the default is true.
+Whether to add an Injection-Date: header field to all local posts.
+This is a boolean value and the default is true.
 
+Note that no Injection-Date: header fields will be added to local posts
+already containing both a Message-ID: header field and a Date: header
+field.  This is done in conformance with standards, to help minimize the
+possibility of a loop in e-mail gatewaying and ensure that the newly
+injected article is not treated as a new, separate article in case of
+multiple injection of the same article to different injecting agents.
+
 =item I<addinjectionpostingaccount>
 
 Whether to add a posting-account attribute to the Injection-Info: header




--- readers.conf.pod	(révision 10171)
+++ readers.conf.pod	(copie de travail)
@@ -512,9 +512,11 @@
 
 If a Date: or an Injection-Date: header field is not included in a
 posted article, nnrpd(8) normally adds these header fields in UTC.
-If this is set to true, the Date: header field will be formatted in
-local time instead.  (The Injection-Date: header field will remain in
-UTC, though.)  This is a boolean value and the default is false.
+If this is set to true, the Date: header field will be formatted in local
+time instead.  (The Injection-Date: header field is added according to
+the behaviour of the I<addinjectiondate> parameter in F<inn.conf>, and
+will remain in UTC, though.)  This is a boolean value and the default
+is false.
 
 This parameter permits to handle a relatively unusual corner case.
 It is mostly a tool for people who I<want> to disclose their local time




--- post.c	(révision 10171)
+++ post.c	(copie de travail)
@@ -387,10 +387,11 @@
         }
     }
 
-    /* Set the Injection-Date: header. */
-    /* Start with this header because it MUST NOT be added in case
+    /* Set the Injection-Date: header field. */
+    /* Start with this header field because it MUST NOT be added in case
      * the article already contains both Message-ID: and Date:
-     * header fields (possibility of multiple injections). */
+     * header fields (possibility of multiple injection, see Sections 3.4.2
+     * and 3.5 of RFC 5537). */
     if (HDR(HDR__INJECTION_DATE) == NULL) {
         /* If moderation is needed, do not add an Injection-Date: header field. */
         if (!needmoderation && PERMaccessconf->addinjectiondate) {


-- 
Julien ÉLIE

« Donner un sens plus pur aux mots de la tribu. » (Stéphane
  Mallarmé)


More information about the inn-workers mailing list