modernize innreport HTML

[Richard Kettlewell]

Without the patch the default behavior does not work properly in modern
web server configrations. The embedded CSS is ignored and the embedded
images caused a mixed context security warning.

Obviously a deployment can fix this up one way or another (in my case, I
patch at build time) but I think the generated HTML ought to work "out
of the box" rather than requiring operator attention.

ttfn/rjk

On 15/05/2020 17:31, Julien ÉLIE wrote:
> Hi Richard,
> 
>> The current design is broken when served over HTTPS or when the
>> webserver has a content security policy. The attached patch fixes both
>> issues.
> 
> Why don't you use the html_css_url parameter in innreport.conf?
> # html_css_url    "innreport.css";
> 
> If set, the HTML page will already contain:
> <link rel="stylesheet" type="text/css" media="all" href="$css_url"/>
> 
> I don't see well the use case of your patch.
> 
> 
> 
> If html_xhtml11_icon and html_vcss_icon are not set in innreport.conf,
> the two icons won't be present in the generated web page, will them?  So
> it does not matter to keep the feature for those who want I think.
> 


ttfn/rjk