ovsqlite

Bo Lindbergh 2bfjdsla52kztwejndzdstsxl9athp at gmail.com
Mon Jan 4 10:36:34 UTC 2021


Quoth Julien ÉLIE <julien at trigofacile.com>:
> 
> Just tried to build INN with SQLite 3.8.2 and it appears that sqlite-helper uses sqlite3_malloc64() which is a function added only in SQLite 3.8.7.
> I therefore suggest to require SQLite 3.8.7.

Those uses allocate an error message buffer.  I'd say it's a safe
assumption that the size won't exceed INT_MAX, so switching to the old
sqlite3_malloc function should be OK.

> To silent a GCC warning, if you're OK with that, I also suggest to add "return 1" at the end of the main function (defined to return an int):

That's a clean exit, so it should return 0.

Patch for both issues attached.


/Bo Lindbergh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: delta5.diff.gz
Type: application/x-gzip
Size: 424 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/inn-workers/attachments/20210104/6adde0a3/attachment.bin>


More information about the inn-workers mailing list