ovsqlite
Julien ÉLIE
julien at trigofacile.com
Mon Jan 4 11:27:47 UTC 2021
Hi Bo,
>> Just tried to build INN with SQLite 3.8.2 and it appears that
>> sqlite-helper uses sqlite3_malloc64() which is a function added only in
>> SQLite 3.8.7.
>> I therefore suggest to require SQLite 3.8.7.
>
> Those uses allocate an error message buffer. I'd say it's a safe
> assumption that the size won't exceed INT_MAX, so switching to the
> old sqlite3_malloc function should be OK.
OK.
>> To silent a GCC warning, if you're OK with that, I also suggest to add "return 1" at the end of the main function (defined to return an int):
>
> That's a clean exit, so it should return 0.
Oh, yes, of course!
> Patch for both issues attached.
Thanks, just applied.
--
Julien ÉLIE
« Donner un sens plus pur aux mots de la tribu. » (Stéphane Mallarmé)
More information about the inn-workers
mailing list