[PATCH] rtconfig/Cisco: make needToPrintNoRouteMap static

Nick Hilliard nick at inex.ie
Sun Jul 12 16:11:49 UTC 2009


On 06/07/2009 23:52, Faidon Liambotis wrote:
> It isn't guranteed, though, that when it is set, that the route-map will
> be printed (e.g. no terms could exist yet). Next invocations of print(),
> however, will reset it to false, hence it will never be printed.
>
> Fix this by making the variable static; the code path that actually
> prints the statement ensures that it gets set back to false, so there
> shouldn't be any breakage.

Yep, problem noted.  I'm not sure if the fix is correct.  Will this deal 
with the situation where you have lots of different route-map names in your 
configuration?  I think we need some more interesting test cases here 
before I'd be happy to commit this.

Nick



More information about the irrtoolset mailing list