[PATCH] peer-as/remote-as directives should refer to a number, not ASnnn
Nick Hilliard
nick at inex.ie
Sun Jul 12 16:25:41 UTC 2009
On 05/07/2009 22:26, Faidon Liambotis wrote:
> This serves as a temporary fix for #34; Nick has expressed some concern
> over the way things are being handled right now in the library and that
> it should be fixed there, rather than being workarounded in rtconfig.
>
> However, there's no harm done in having something working sooner than
> later, even if in a hackish way.
I'm not going to commit this. The library fix is as follows:
> --- src/rpsl/rpsl_filter.cc (revision 281)
> +++ src/rpsl/rpsl_filter.cc (working copy)
> @@ -105,7 +105,7 @@
> }
>
> ostream &FilterASNO::print(ostream &out) const {
> - out << "AS" << asno;
> + out << asno;
> return out;
> }
[apologies for diff mangling here - recent nightlies of Thunderbird3 have
seriously broken cut-n-paste].
I'd prefer to commit this to the library and then fix all other things
which broke using "blahout << "AS" << asno", rather than messing things up
with typecasts. Typecasting is the wrong thing to do.
The problem is nailing these things down. I don't think there are very
many instances where it would cause breakage, and I also don't think that
the breakage is going to be very bad, but there's so much inheritance
insanity going on in the code that it's very difficult to tell.
What do you think about this patch to rpsl_filter.cc and this approach to
fixing the problem?
Nick
More information about the irrtoolset
mailing list