[PATCH] peer-as/remote-as directives should refer to a number, not ASnnn

Faidon Liambotis paravoid at debian.org
Sun Jul 12 16:34:40 UTC 2009


Nick Hilliard wrote:
> I'd prefer to commit this to the library and then fix all other things
> which broke using "blahout << "AS" << asno", rather than messing things
> up with typecasts.  Typecasting is the wrong thing to do.
> 
> The problem is nailing these things down.  I don't think there are very
> many instances where it would cause breakage, and I also don't think
> that the breakage is going to be very bad, but there's so much
> inheritance insanity going on in the code that it's very difficult to tell.
> 
> What do you think about this patch to rpsl_filter.cc and this approach
> to fixing the problem?
Agreed.

I wasn't sure what were the library fixes that you mentioned and how
intrusive they were, hence my patch which only meant to be applied as an
interim solution.

I'll try to have a look at the repercussions of such a change within the
week.

Thanks,
Faidon



More information about the irrtoolset mailing list